Bug 217331

Summary: Make value parameter in Document.execCommand non nullable
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, mifenton, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Rob Buis
Reported 2020-10-05 13:18:29 PDT
Make value parameter in Document.execCommand non nullable [1]. [1] https://html.spec.whatwg.org/#document
Attachments
Patch (4.25 KB, patch)
2020-10-05 13:20 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2020-10-05 23:31 PDT, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2020-10-06 01:26 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-10-05 13:20:51 PDT
Created attachment 410547 [details] Patch
Sam Weinig
Comment 2 2020-10-05 17:09:34 PDT
Comment on attachment 410547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review > Source/WebCore/dom/Document+HTML.idl:71 > + [CEReactions] boolean execCommand(DOMString commandId, optional boolean showUI = false, optional DOMString value = null); I think the default value is supposed to be "". Are you planning to fix that in a follow up? If you wanted to, you could just do them all at one.
Rob Buis
Comment 3 2020-10-05 23:31:57 PDT
Created attachment 410616 [details] Patch
Rob Buis
Comment 4 2020-10-06 01:26:32 PDT
Created attachment 410618 [details] Patch
EWS
Comment 5 2020-10-06 02:34:50 PDT
Committed r268043: <https://trac.webkit.org/changeset/268043> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410618 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-06 02:35:20 PDT
<rdar://problem/69992245>
Darin Adler
Comment 7 2020-10-18 14:42:07 PDT
Comment on attachment 410547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review > LayoutTests/editing/execCommand/arguments-combinations-expected.txt:10 > +PASS <hr id="null"> is <hr id="null"> Nice how poor the output from this test is, no clue of what's being tested. We should come back to this and rearrange the test so the output is useful.
Darin Adler
Comment 8 2020-10-18 14:42:35 PDT
(In reply to Darin Adler from comment #7) > Nice how poor the output from this test is, no clue of what's being tested. > We should come back to this and rearrange the test so the output is useful. *Notice*, not *Nice*.
Note You need to log in before you can comment on or make changes to this bug.