Bug 217302

Summary: Add implementation of <filesystem> to WTF for macOS 10.14
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ap, benjamin, cdumez, cmarcelo, darin, ews-watchlist, gyuyoung.kim, mjs, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2020-10-04 17:21:16 PDT
Add implementation of <filesystem> to WTF for macOS 10.14
Attachments
Patch (166.13 KB, patch)
2020-10-04 17:26 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (164.64 KB, patch)
2020-10-04 17:49 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (164.69 KB, patch)
2020-10-04 17:55 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (164.69 KB, patch)
2020-10-04 18:20 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (164.69 KB, patch)
2020-10-04 19:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (168.50 KB, patch)
2020-10-05 16:36 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-04 17:26:23 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-10-04 17:49:31 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-10-04 17:55:49 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-10-04 18:20:53 PDT
Created attachment 410494 [details] Patch
Sam Weinig
Comment 5 2020-10-04 18:30:55 PDT
Alexey, given the existing MIT licensed code, and that these files are dual licensed under the MIT and the University of Illinois Open Source Licenses, do you have concerns about landing this?
Konstantin Tokarev
Comment 6 2020-10-04 18:49:31 PDT
Comment on attachment 410494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410494&action=review > Source/WTF/ChangeLog:9 > + from libc++ (628a319475) and modifies them to build outside of This doesn't match actually imported revision
Alexey Proskuryakov
Comment 7 2020-10-04 18:55:37 PDT
I'm honestly not sure. Maciej may know the rules.
Sam Weinig
Comment 8 2020-10-04 19:03:05 PDT
Created attachment 410496 [details] Patch
Sam Weinig
Comment 9 2020-10-04 19:03:12 PDT
(In reply to Konstantin Tokarev from comment #6) > Comment on attachment 410494 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410494&action=review > > > Source/WTF/ChangeLog:9 > > + from libc++ (628a319475) and modifies them to build outside of > > This doesn't match actually imported revision Oops. I went back to an older revision so that it would actually build on 10.14. Fixed.
Sam Weinig
Comment 10 2020-10-05 16:36:25 PDT
Created attachment 410586 [details] Patch
EWS
Comment 11 2020-10-05 17:28:11 PDT
Committed r268020: <https://trac.webkit.org/changeset/268020> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410586 [details].
Radar WebKit Bug Importer
Comment 12 2020-10-05 17:29:17 PDT
<rdar://problem/69978322>
Note You need to log in before you can comment on or make changes to this bug.