Bug 217302 - Add implementation of <filesystem> to WTF for macOS 10.14
Summary: Add implementation of <filesystem> to WTF for macOS 10.14
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-04 17:21 PDT by Sam Weinig
Modified: 2020-10-05 17:29 PDT (History)
12 users (show)

See Also:

Attachments
Patch (166.13 KB, patch)
2020-10-04 17:26 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (164.64 KB, patch)
2020-10-04 17:49 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (164.69 KB, patch)
2020-10-04 17:55 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (164.69 KB, patch)
2020-10-04 18:20 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (164.69 KB, patch)
2020-10-04 19:03 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (168.50 KB, patch)
2020-10-05 16:36 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-04 17:21:16 PDT 
Add implementation of <filesystem> to WTF for macOS 10.14
Comment 1 Sam Weinig 2020-10-04 17:26:23 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-04 17:49:31 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-04 17:55:49 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-10-04 18:20:53 PDT 
Created attachment 410494 [details]
Patch
Comment 5 Sam Weinig 2020-10-04 18:30:55 PDT 
Alexey, given the existing MIT licensed code, and that these files are dual licensed under the MIT and the University of Illinois Open Source Licenses, do you have concerns about landing this?
Comment 6 Konstantin Tokarev 2020-10-04 18:49:31 PDT 
Comment on attachment 410494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410494&action=review

> Source/WTF/ChangeLog:9
> +        from libc++ (628a319475) and modifies them to build outside of

This doesn't match actually imported revision
Comment 7 Alexey Proskuryakov 2020-10-04 18:55:37 PDT 
I'm honestly not sure. Maciej may know the rules.
Comment 8 Sam Weinig 2020-10-04 19:03:05 PDT 
Created attachment 410496 [details]
Patch
Comment 9 Sam Weinig 2020-10-04 19:03:12 PDT 
(In reply to Konstantin Tokarev from comment #6)
> Comment on attachment 410494 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410494&action=review
> 
> > Source/WTF/ChangeLog:9
> > +        from libc++ (628a319475) and modifies them to build outside of
> 
> This doesn't match actually imported revision

Oops. I went back to an older revision so that it would actually build on 10.14. Fixed.
Comment 10 Sam Weinig 2020-10-05 16:36:25 PDT 
Created attachment 410586 [details]
Patch
Comment 11 EWS 2020-10-05 17:28:11 PDT 
Committed r268020: <https://trac.webkit.org/changeset/268020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410586 [details].
Comment 12 Radar WebKit Bug Importer 2020-10-05 17:29:17 PDT 
<rdar://problem/69978322>