Bug 217296

Summary: Make xhr.response more conforming to the specification
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-10-04 09:16:50 PDT
Make xhr.response more conforming to the specification when dealing with Blob type responses, the type for the Blob should be computed by the "get a final MIME type" algorithm [1, 2]. [1] https://xhr.spec.whatwg.org/#ref-for-final-mime-type③ [2] https://xhr.spec.whatwg.org/#final-mime-type
Attachments
Patch (18.02 KB, patch)
2020-10-04 09:26 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (19.50 KB, patch)
2020-10-04 11:21 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (19.53 KB, patch)
2020-10-05 01:56 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-10-04 09:26:51 PDT
Created attachment 410469 [details] Patch
Rob Buis
Comment 2 2020-10-04 11:21:57 PDT
Created attachment 410473 [details] Patch
Darin Adler
Comment 3 2020-10-04 14:27:38 PDT
Comment on attachment 410473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410473&action=review > Source/WebCore/xml/XMLHttpRequest.h:94 > + enum class FinalMIMEType { Yes, No }; > + String responseMIMEType(FinalMIMEType = FinalMIMEType::No) const; What does "final MIME type" mean?
Darin Adler
Comment 4 2020-10-04 14:28:03 PDT
Comment on attachment 410473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410473&action=review >> Source/WebCore/xml/XMLHttpRequest.h:94 >> + String responseMIMEType(FinalMIMEType = FinalMIMEType::No) const; > > What does "final MIME type" mean? I guess it’s a term from the specification?
Rob Buis
Comment 5 2020-10-05 01:56:37 PDT
Created attachment 410510 [details] Patch
Rob Buis
Comment 6 2020-10-05 03:16:48 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 410473 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410473&action=review > > >> Source/WebCore/xml/XMLHttpRequest.h:94 > >> + String responseMIMEType(FinalMIMEType = FinalMIMEType::No) const; > > > > What does "final MIME type" mean? > > I guess it’s a term from the specification? Yes, it should be explained in the ChangeLog/Changelog links.
EWS
Comment 7 2020-10-05 03:30:38 PDT
Committed r267959: <https://trac.webkit.org/changeset/267959> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410510 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-05 03:31:21 PDT
<rdar://problem/69948052>
Note You need to log in before you can comment on or make changes to this bug.