Bug 217256

Summary: AX: Expose lineRangeForPosition for iOS Accessibility code
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
zalan: review+
patch none

chris fleizach
Reported 2020-10-02 15:47:01 PDT
IOS needs to make use of the existing lineRangeForPosition method
Attachments
patch (2.33 KB, patch)
2020-10-02 15:48 PDT, chris fleizach 		zalan: review+
DetailsFormatted DiffDiff
patch (2.48 KB, patch)
2020-10-06 11:37 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2020-10-02 15:47:17 PDT
<rdar://problem/67478962>
chris fleizach
Comment 2 2020-10-02 15:48:22 PDT
Created attachment 410384 [details] patch
alan
Comment 3 2020-10-05 15:50:28 PDT
Comment on attachment 410384 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=410384&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2689 > + auto *startMarker = [WebAccessibilityTextMarker textMarkerWithVisiblePosition:range.start cache:self.axBackingObject->axObjectCache()]; > + auto *endMarker = [WebAccessibilityTextMarker textMarkerWithVisiblePosition:range.end cache:self.axBackingObject->axObjectCache()]; auto* start/endMarker
chris fleizach
Comment 4 2020-10-06 11:37:13 PDT
Created attachment 410671 [details] patch Updated
EWS
Comment 5 2020-10-06 16:21:38 PDT
Committed r268084: <https://trac.webkit.org/changeset/268084> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410671 [details].
Note You need to log in before you can comment on or make changes to this bug.