Bug 217251

Summary: Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217242    
Bug Blocks: 217058, 217405    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2020-10-02 15:03:18 PDT
Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes.
Attachments
Patch (12.87 KB, patch)
2020-10-02 15:17 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.16 KB, patch)
2020-10-06 10:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-02 15:17:29 PDT
Created attachment 410378 [details] Patch
Chris Dumez
Comment 2 2020-10-06 10:30:25 PDT
Created attachment 410654 [details] Patch
Chris Dumez
Comment 3 2020-10-06 14:29:16 PDT
Patch is ready for review.
Geoffrey Garen
Comment 4 2020-10-06 14:38:22 PDT
Comment on attachment 410654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410654&action=review r=me > Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:105 > + if (auto* audioWorkletGlobalScope = audioWorkletProxy->workletThread().globalScope()) Maybe workletThread().globalScope() should encode this comment as an ASSERT or as a RELEASE_ASSERT.
EWS
Comment 5 2020-10-06 14:53:13 PDT
Committed r268076: <https://trac.webkit.org/changeset/268076> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410654 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-06 14:54:22 PDT
<rdar://problem/70018632>
Note You need to log in before you can comment on or make changes to this bug.