Bug 217251

Summary:

Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

217242

Bug Blocks:

217058, 217405

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Chris Dumez 2020-10-02 15:03:18 PDT

Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes.

Comment 1 Chris Dumez 2020-10-02 15:17:29 PDT

Created attachment 410378 [details]
Patch

Comment 2 Chris Dumez 2020-10-06 10:30:25 PDT

Created attachment 410654 [details]
Patch

Comment 3 Chris Dumez 2020-10-06 14:29:16 PDT

Patch is ready for review.

Comment 4 Geoffrey Garen 2020-10-06 14:38:22 PDT

Comment on attachment 410654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410654&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:105
> +        if (auto* audioWorkletGlobalScope = audioWorkletProxy->workletThread().globalScope())

Maybe workletThread().globalScope() should encode this comment as an ASSERT or as a RELEASE_ASSERT.

Comment 5 EWS 2020-10-06 14:53:13 PDT

Committed r268076: <https://trac.webkit.org/changeset/268076>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410654 [details].

Comment 6 Radar WebKit Bug Importer 2020-10-06 14:54:22 PDT

<rdar://problem/70018632>