Bug 217247

Summary: Simplify and harden idl_files.tmp generation
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2020-10-02 13:43:26 PDT
Simplify and harden idl_files.tmp generation
Attachments
Patch (4.38 KB, patch)
2020-10-02 13:48 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (4.43 KB, patch)
2020-10-02 14:08 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-02 13:48:06 PDT
Created attachment 410363 [details] Patch
Sam Weinig
Comment 2 2020-10-02 13:49:48 PDT
We don't have to actually remove the delete, but I don't see the benefit in keeping it either.
Darin Adler
Comment 3 2020-10-02 13:51:08 PDT
Comment on attachment 410363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410363&action=review > Source/WebCore/DerivedSources.make:1774 > + $(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > idl_files.tmp) Why not name the file something like JSBindingIDLs.txt instead of idl_files.tmp?
Sam Weinig
Comment 4 2020-10-02 14:08:26 PDT
Created attachment 410367 [details] Patch
Sam Weinig
Comment 5 2020-10-02 14:08:34 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 410363 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410363&action=review > > > Source/WebCore/DerivedSources.make:1774 > > + $(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > idl_files.tmp) > > Why not name the file something like JSBindingIDLs.txt instead of > idl_files.tmp? Indeed.
EWS
Comment 6 2020-10-03 10:02:43 PDT
Committed r267928: <https://trac.webkit.org/changeset/267928> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410367 [details].
Radar WebKit Bug Importer
Comment 7 2020-10-03 10:03:18 PDT
<rdar://problem/69916929>
Note You need to log in before you can comment on or make changes to this bug.