Summary: | [Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector is about to close | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Blaze Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | Blaze Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Blaze Burg
2020-10-02 10:20:09 PDT
Created attachment 410341 [details]
Patch
Comment on attachment 410341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410341&action=review r=me as well :) > Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:522 > + // Guard against calls to close() made by the client while already closing. Should we have something similar for `show()` too? Also, can we make an API test for this? > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:122 > +TEST(WKInspectorDelegate, WillCloseLocalInspector) IMO why not just combine these two tests and call it something like "OpenCloseLifecycle"? Comment on attachment 410341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410341&action=review >> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:522 >> + // Guard against calls to close() made by the client while already closing. > > Should we have something similar for `show()` too? > > Also, can we make an API test for this? OK >> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:122 >> +TEST(WKInspectorDelegate, WillCloseLocalInspector) > > IMO why not just combine these two tests and call it something like "OpenCloseLifecycle"? I want to isolate the Browser domain callbacks as that could break independently of the UIDelegate methods. Created attachment 410481 [details]
Patch
Committed r267950: <https://trac.webkit.org/changeset/267950> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410481 [details]. |