Bug 217229

Summary: [macOS] Enable date, time, and datetime-local input types
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, hi, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
sam: review+
Patch for landing none

Aditya Keerthi
Reported 2020-10-02 09:05:54 PDT
...
Attachments
Patch (1.83 KB, patch)
2020-10-02 09:08 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (7.02 KB, patch)
2020-10-02 12:47 PDT, Aditya Keerthi 		sam: review+
DetailsFormatted DiffDiff
Patch for landing (7.11 KB, patch)
2020-10-02 13:46 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-10-02 09:06:07 PDT
<rdar://problem/69882757>
Aditya Keerthi
Comment 2 2020-10-02 09:08:54 PDT
Created attachment 410329 [details] Patch
Aditya Keerthi
Comment 3 2020-10-02 12:47:10 PDT
Created attachment 410356 [details] Patch
Sam Weinig
Comment 4 2020-10-02 13:25:41 PDT
Comment on attachment 410356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410356&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304 > - "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true > + "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true > default: false Lol, I made this way more confusing than I intended to. Should probably switch these to: "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false default: true Right?
Aditya Keerthi
Comment 5 2020-10-02 13:46:07 PDT
Created attachment 410362 [details] Patch for landing
Aditya Keerthi
Comment 6 2020-10-02 13:47:28 PDT
(In reply to Sam Weinig from comment #4) > Comment on attachment 410356 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410356&action=review > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304 > > - "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true > > + "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true > > default: false > > Lol, I made this way more confusing than I intended to. Should probably > switch these to: > > "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false > default: true > > Right? Good call.
EWS
Comment 7 2020-10-03 09:21:41 PDT
Committed r267926: <https://trac.webkit.org/changeset/267926> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410362 [details].
Note You need to log in before you can comment on or make changes to this bug.