Bug 217229

Summary: [macOS] Enable date, time, and datetime-local input types
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, hi, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
sam: review+
Patch for landing none

Description Aditya Keerthi 2020-10-02 09:05:54 PDT 
...
Comment 1 Aditya Keerthi 2020-10-02 09:06:07 PDT 
<rdar://problem/69882757>
Comment 2 Aditya Keerthi 2020-10-02 09:08:54 PDT 
Created attachment 410329 [details]
Patch
Comment 3 Aditya Keerthi 2020-10-02 12:47:10 PDT 
Created attachment 410356 [details]
Patch
Comment 4 Sam Weinig 2020-10-02 13:25:41 PDT 
Comment on attachment 410356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410356&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304
> -      "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> +      "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
>        default: false

Lol, I made this way more confusing than I intended to. Should probably switch these to:

"PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
default: true

Right?
Comment 5 Aditya Keerthi 2020-10-02 13:46:07 PDT 
Created attachment 410362 [details]
Patch for landing
Comment 6 Aditya Keerthi 2020-10-02 13:47:28 PDT 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 410356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410356&action=review
> 
> > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304
> > -      "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> > +      "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> >        default: false
> 
> Lol, I made this way more confusing than I intended to. Should probably
> switch these to:
> 
> "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
> default: true
> 
> Right?

Good call.
Comment 7 EWS 2020-10-03 09:21:41 PDT 
Committed r267926: <https://trac.webkit.org/changeset/267926>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410362 [details].