Bug 21717

Summary:

Need to test Geolocation when platform doesn't have implementation

Product:

WebKit

Reporter:

Greg Bolsinga <bolsinga>

Component:

WebKit Misc.

Assignee:

Greg Bolsinga <bolsinga>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

abarth, ddkilzer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.5

Attachments:

Description	Flags
This is a GeolocationServiceFake implementation and test cases	none

Greg Bolsinga

Reported 2008-10-17 14:47:28 PDT

For bug https://bugs.webkit.org/show_bug.cgi?id=21475 a GeolocationServiceFake was attempted when the platform doesn't have a GeolocationService of its own. This would also have to not 'leak' into WebCore as a property on navigator when not in testing mode. The ways in the patches in that bug would leak this property out. I have attached the files here for the tests and the implementation of GeolocationServiceFake. For Geolocation and Navigator, custom toJS and IDL and hasOwnProperty methods are probably in the mix for what is necessary.

Attachments
This is a GeolocationServiceFake implementation and test cases (2.25 KB, application/octet-stream) 2008-10-17 14:48 PDT, Greg Bolsinga	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Greg Bolsinga

Comment 1 2008-10-17 14:48:54 PDT

Created attachment 24464 [details] This is a GeolocationServiceFake implementation and test cases

Greg Bolsinga

Comment 2 2009-07-08 14:28:43 PDT

-r45634 with an oddly super-long svn commit log.

Greg Bolsinga

Comment 3 2009-07-08 14:29:26 PDT

Crap. Not supposed close that one.

Adam Barth

Comment 4 2009-09-04 12:59:20 PDT

Looks like this is going to be worked on in Bug 28264. *** This bug has been marked as a duplicate of bug 28264 ***

Note You need to log in before you can comment on or make changes to this bug.