Summary: | Add AVAssetWriter SPI header | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, tsavell, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2020-10-01 02:17:37 PDT
Created attachment 410211 [details]
Patch
Created attachment 410215 [details]
Patch
Created attachment 410224 [details]
Patch
Committed r267841: <https://trac.webkit.org/changeset/267841> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410224 [details]. It looks like this patch broke OpenSource Catalina Builds https://build.webkit.org/builders/Apple-Catalina-Release-Build/builds/10761 ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:49: error: unknown class name 'AVAssetWriterDelegate'; did you mean 'WebAVAssetWriterDelegate'? ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:49: error: type argument 'WebAVAssetWriterDelegate' must be a pointer (requires a '*') ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:39: error: type arguments cannot be applied to non-parameterized class 'NSObject' ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:166:21: error: 'AVAssetWriter' may not respond to 'setDelegate:' [-Werror] ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:166:33: error: incompatible pointer types sending 'WTF::RetainPtr<WebAVAssetWriterDelegate>::PtrType' (aka 'WebAVAssetWriterDelegate *') to parameter of type 'id<NSFileManagerDelegate> _Nullable' [-Werror,-Wincompatible-pointer-types] Reverted r267841 for reason: Broke Catalina Builds Committed r267849: <https://trac.webkit.org/changeset/267849> Created attachment 410305 [details]
Patch
Committed r267870: <https://trac.webkit.org/changeset/267870> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410305 [details]. |