Bug 217169

Summary: Add AVAssetWriter SPI header
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2020-10-01 02:17:37 PDT
Add AVAssetWriter SPI header
Attachments
Patch (12.41 KB, patch)
2020-10-01 02:27 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.46 KB, patch)
2020-10-01 03:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.43 KB, patch)
2020-10-01 05:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (14.40 KB, patch)
2020-10-02 01:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-10-01 02:18:03 PDT
<rdar://problem/69793050>
youenn fablet
Comment 2 2020-10-01 02:27:58 PDT
Created attachment 410211 [details] Patch
youenn fablet
Comment 3 2020-10-01 03:22:08 PDT
Created attachment 410215 [details] Patch
youenn fablet
Comment 4 2020-10-01 05:57:16 PDT
Created attachment 410224 [details] Patch
EWS
Comment 5 2020-10-01 10:28:57 PDT
Committed r267841: <https://trac.webkit.org/changeset/267841> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410224 [details].
Truitt Savell
Comment 6 2020-10-01 13:04:21 PDT
It looks like this patch broke OpenSource Catalina Builds https://build.webkit.org/builders/Apple-Catalina-Release-Build/builds/10761 ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:49: error: unknown class name 'AVAssetWriterDelegate'; did you mean 'WebAVAssetWriterDelegate'? ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:49: error: type argument 'WebAVAssetWriterDelegate' must be a pointer (requires a '*') ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:50:39: error: type arguments cannot be applied to non-parameterized class 'NSObject' ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:166:21: error: 'AVAssetWriter' may not respond to 'setDelegate:' [-Werror] ./platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:166:33: error: incompatible pointer types sending 'WTF::RetainPtr<WebAVAssetWriterDelegate>::PtrType' (aka 'WebAVAssetWriterDelegate *') to parameter of type 'id<NSFileManagerDelegate> _Nullable' [-Werror,-Wincompatible-pointer-types]
Truitt Savell
Comment 7 2020-10-01 13:05:13 PDT
Reverted r267841 for reason: Broke Catalina Builds Committed r267849: <https://trac.webkit.org/changeset/267849>
youenn fablet
Comment 8 2020-10-02 01:03:43 PDT
Created attachment 410305 [details] Patch
EWS
Comment 9 2020-10-02 02:38:57 PDT
Committed r267870: <https://trac.webkit.org/changeset/267870> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410305 [details].
Note You need to log in before you can comment on or make changes to this bug.