| Summary: | [JSC] Define Array#sort's implementation functions as globalPrivate | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=217928 | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-10-01 01:16:20 PDT
Created attachment 410205 [details]
Patch
Comment on attachment 410205 [details]
Patch
LGTM. I wonder if there are other builtins that still have locally-defined functions though?
(In reply to Ross Kirsling from comment #2) > Comment on attachment 410205 [details] > Patch > > LGTM. I wonder if there are other builtins that still have locally-defined > functions though? There are several ones. We should apply similar changes. Committed r267827: <https://trac.webkit.org/changeset/267827> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410205 [details]. |