Bug 217168

Summary: [JSC] Define Array#sort's implementation functions as globalPrivate
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217928
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2020-10-01 01:16:20 PDT
[JSC] Define Array#sort's implementation functions as globalPrivate
Attachments
Patch (11.17 KB, patch)
2020-10-01 01:17 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-10-01 01:17:16 PDT
Created attachment 410205 [details] Patch
Ross Kirsling
Comment 2 2020-10-01 01:19:42 PDT
Comment on attachment 410205 [details] Patch LGTM. I wonder if there are other builtins that still have locally-defined functions though?
Yusuke Suzuki
Comment 3 2020-10-01 01:22:30 PDT
(In reply to Ross Kirsling from comment #2) > Comment on attachment 410205 [details] > Patch > > LGTM. I wonder if there are other builtins that still have locally-defined > functions though? There are several ones. We should apply similar changes.
EWS
Comment 4 2020-10-01 04:03:44 PDT
Committed r267827: <https://trac.webkit.org/changeset/267827> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410205 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-01 04:04:14 PDT
<rdar://problem/69831089>
Note You need to log in before you can comment on or make changes to this bug.