Bug 21715

Summary:

JavaScriptDebugServer::didRemoveListener should recompile all JS functions

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kmccullough, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	ggaren: review+

Geoffrey Garen

Reported 2008-10-17 13:39:24 PDT

Currently, we only recompile when removing the last listener. We should instead recompile when removing any listener. This would match the behavior of didAddListener, and ensure that, when multiple debuggers are running, closing one returns its page to normal, fast-running mode.

Attachments
Proposed patch (3.60 KB, patch) 2008-10-17 14:03 PDT, Timothy Hatcher	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2008-10-17 14:03:07 PDT

Created attachment 24461 [details] Proposed patch

Geoffrey Garen

Comment 2 2008-10-17 14:03:56 PDT

Comment on attachment 24461 [details] Proposed patch r=me

Timothy Hatcher

Comment 3 2008-10-17 14:05:02 PDT

Comment on attachment 24461 [details] Proposed patch Landed in r37659.

Note You need to log in before you can comment on or make changes to this bug.