Summary: | Expose pvrtc extension without vendor prefix and remove redundant WebGL 2 extensions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||
Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 126404 | ||||||||
Attachments: |
|
Description
James Darpinian
2020-09-29 16:51:16 PDT
Created attachment 410067 [details]
Patch
Comment on attachment 410067 [details]
Patch
Looks good to me assuming you've tested these changes locally with the associated extension tests; if an extension spontaneously stops getting supported then the current layout tests won't catch that, and will still pass. r+
Found 1 new test failure: webgl/2.0.0/conformance2/extensions/promoted-extensions.html Created attachment 410169 [details]
Patch
Committed r267811: <https://trac.webkit.org/changeset/267811> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410169 [details]. |