Bug 217101

Summary: [WebIDL] Make Exposed mandatory for IDL interfaces
Product: WebKit Reporter: Sam Weinig <sam>
Component: BindingsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cdumez, changseok, cmarcelo, darin, dbarton, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, graouts, gyuyoung.kim, hi, hta, japhet, jer.noble, jiewen_tan, kangil.han, kondapallykalyan, macpherson, menard, mifenton, mmaxfield, pdr, philipj, sabouhallawa, schenney, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2020-09-29 13:21:26 PDT
Let's bite the bullet and make Exposed mandatory for IDL interfaces (matching WebIDL), and stop the silliness of inferring Window.
Attachments
Patch (457.90 KB, patch)
2020-09-30 15:21 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-30 15:21:49 PDT
Created attachment 410157 [details] Patch
Darin Adler
Comment 2 2020-09-30 15:48:15 PDT
Comment on attachment 410157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410157&action=review > Source/WebCore/Modules/applepay/ApplePaySetup.idl:31 > SecureContext, > + Exposed=Window Looks like the existing ones above are sorted alphabetically, but this new one is not.
Darin Adler
Comment 3 2020-09-30 15:48:36 PDT
Comment on attachment 410157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410157&action=review >> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31 >> + Exposed=Window > > Looks like the existing ones above are sorted alphabetically, but this new one is not. Many other cases like this.
Sam Weinig
Comment 4 2020-09-30 15:57:27 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 410157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410157&action=review > > >> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31 > >> + Exposed=Window > > > > Looks like the existing ones above are sorted alphabetically, but this new one is not. > > Many other cases like this. I'm going to write a script to check this (like I just did with the preferences) or just make the parser enforce it.
EWS
Comment 5 2020-09-30 17:16:02 PDT
Committed r267813: <https://trac.webkit.org/changeset/267813> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410157 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-30 17:17:19 PDT
<rdar://problem/69815504>
Note You need to log in before you can comment on or make changes to this bug.