Bug 217096 – Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.

• Component: New Bugs
• Status: RESOLVED FIXED

[Andres Gonzalez]

Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests.

[Andres Gonzalez]

Created attachment 410024 [details]
Patch

[chris fleizach]

Comment on attachment 410024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410024&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38
> +    ASSERT_NOT_REACHED(); \

if we're going to assert here, do we even need to do anything else?

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 410024 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410024&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38
> > +    ASSERT_NOT_REACHED(); \
> 
> if we're going to assert here, do we even need to do anything else?

The original intention is to re-throw the exceptions that are not NSAccessibilityExceptions. So I wouldn't want to change that behavior in release builds in case someone/something depends on it.

[EWS]

Committed r267774: <https://trac.webkit.org/changeset/267774>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410024 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69772194>