| Summary: | [JSC] Annotate JIT operation functions called from B3 etc. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Yusuke Suzuki
2020-09-29 01:18:53 PDT
Created attachment 409972 [details]
Patch
Created attachment 409974 [details]
Patch
Created attachment 409975 [details]
Patch
Created attachment 409977 [details]
Patch
Comment on attachment 409977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409977&action=review > Source/JavaScriptCore/b3/B3ReduceLoopStrength.h:46 > +ALWAYS_INLINE void fastForwardCopy32(uint32_t* dst, const uint32_t* src, size_t size) why not put this in the cpp file? Comment on attachment 409977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409977&action=review >> Source/JavaScriptCore/b3/B3ReduceLoopStrength.h:46 >> +ALWAYS_INLINE void fastForwardCopy32(uint32_t* dst, const uint32_t* src, size_t size) > > why not put this in the cpp file? Since it is also used by testb3. I don't want to create two duplicate machine code functions for `operationFastForwardCopy32` and `fastForwardCopy32`. And currently, operation is not supported to be exposed as JS_EXPORT_PRIVATE Committed r267754: <https://trac.webkit.org/changeset/267754> |