Bug 217082

Summary: [JSC] Annotate JIT operation functions called from B3 etc.
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2020-09-29 01:18:53 PDT
[JSC] Annotate JIT operation functions called from B3 etc.
Attachments
Patch (40.62 KB, patch)
2020-09-29 01:20 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (40.55 KB, patch)
2020-09-29 01:24 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (42.45 KB, patch)
2020-09-29 01:32 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (42.42 KB, patch)
2020-09-29 02:05 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-09-29 01:20:03 PDT
Created attachment 409972 [details] Patch
Yusuke Suzuki
Comment 2 2020-09-29 01:24:46 PDT
Created attachment 409974 [details] Patch
Yusuke Suzuki
Comment 3 2020-09-29 01:32:54 PDT
Created attachment 409975 [details] Patch
Yusuke Suzuki
Comment 4 2020-09-29 02:05:48 PDT
Created attachment 409977 [details] Patch
Saam Barati
Comment 5 2020-09-29 09:55:47 PDT
Comment on attachment 409977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409977&action=review > Source/JavaScriptCore/b3/B3ReduceLoopStrength.h:46 > +ALWAYS_INLINE void fastForwardCopy32(uint32_t* dst, const uint32_t* src, size_t size) why not put this in the cpp file?
Yusuke Suzuki
Comment 6 2020-09-29 11:10:17 PDT
Comment on attachment 409977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409977&action=review >> Source/JavaScriptCore/b3/B3ReduceLoopStrength.h:46 >> +ALWAYS_INLINE void fastForwardCopy32(uint32_t* dst, const uint32_t* src, size_t size) > > why not put this in the cpp file? Since it is also used by testb3. I don't want to create two duplicate machine code functions for `operationFastForwardCopy32` and `fastForwardCopy32`. And currently, operation is not supported to be exposed as JS_EXPORT_PRIVATE
Yusuke Suzuki
Comment 7 2020-09-29 11:12:35 PDT
Committed r267754: <https://trac.webkit.org/changeset/267754>
Radar WebKit Bug Importer
Comment 8 2020-09-29 11:13:21 PDT
<rdar://problem/69755354>
Note You need to log in before you can comment on or make changes to this bug.