Bug 21708

Summary:

REGRESSION(r37622): starting a debugging session in another Web Inspector does show any scripts

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Major

CC:

aroben, ggaren, kmccullough, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	darin: review+

Description Timothy Hatcher 2008-10-17 09:28:48 PDT

Steps:
1) Start debugging a page in one window.
2) Start debugging a page in another window.

Results:
The second window Web Inspector is empty and shows no scripts.

Comment 1 Timothy Hatcher 2008-10-17 09:33:02 PDT

Created attachment 24458 [details]
Proposed patch

Comment 2 Darin Adler 2008-10-17 09:37:18 PDT

Comment on attachment 24458 [details]
Proposed patch

+        void didAddListener(Page* page = 0);
+        void didRemoveListener(Page* page = 0);

Don't need the name "page" here for the argument. Seems unclear what the "0" value means. I guess it means "global listener", but that should be mentioned explicitly.

r=me

Comment 3 Timothy Hatcher 2008-10-17 09:51:47 PDT

Landed in r37656. Removed the default arguments.