Bug 217015

Summary: [Preferences] Generate Debug and Internal preferences for WebKitLegacy
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2020-09-26 14:53:57 PDT
[Preferences] Generate Debug and Internal preferences for WebKitLegacy
Attachments
Patch (63.67 KB, patch)
2020-09-26 14:58 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (63.61 KB, patch)
2020-09-26 15:55 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-26 14:58:12 PDT
Created attachment 409793 [details] Patch
Darin Adler
Comment 2 2020-09-26 15:07:51 PDT
Comment on attachment 409793 [details] Patch Another step in the right direction. Really need to keep going so we can delete huge swathes of this code. In particular, need to stop adding code just to plumb through features we want to test when we have no intention of offering them to enable/disable as API or SPI. And if we have legacy API and SPI that we need to keep around, would like this to be a small shim, not a lot of hand-written code.
Sam Weinig
Comment 3 2020-09-26 15:55:39 PDT
Created attachment 409797 [details] Patch
EWS
Comment 4 2020-09-26 17:21:07 PDT
Committed r267641: <https://trac.webkit.org/changeset/267641> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409797 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-26 17:22:16 PDT
<rdar://problem/69638185>
Note You need to log in before you can comment on or make changes to this bug.