Summary: | Support OES_fbo_render_mipmap | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||
Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, annulen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, pyalot, ryuan.choi, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 215599 | ||||||
Bug Blocks: | 141242, 216014 | ||||||
Attachments: |
|
Description
James Darpinian
2020-09-25 16:50:59 PDT
Created attachment 409761 [details]
Patch
Comment on attachment 409761 [details]
Patch
Looks good to me. Have you verified locally that the extension test goes down the code path where the extension's enabled? r+
Comment on attachment 409761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409761&action=review > Source/WebCore/html/canvas/OESFBORenderMipmap.h:33 > + WTF_MAKE_ISO_ALLOCATED(OESFBORenderMipmap); Thanks for this. We missed that sub-classes need it in the patch where we added IsoHeap allocation to WebGLExtension and it ended up as the number 1 WebKit crash in iOS 14 :) Comment on attachment 409761 [details]
Patch
Yes, the extension works locally. Thanks!
Committed r267613: <https://trac.webkit.org/changeset/267613> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409761 [details]. (In reply to Dean Jackson from comment #3) > Comment on attachment 409761 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409761&action=review > > > Source/WebCore/html/canvas/OESFBORenderMipmap.h:33 > > + WTF_MAKE_ISO_ALLOCATED(OESFBORenderMipmap); > > Thanks for this. We missed that sub-classes need it in the patch where we > added IsoHeap allocation to WebGLExtension and it ended up as the number 1 > WebKit crash in iOS 14 :) I think that was my patch from Bug 215599 - I'm sorry for breaking things! *** Bug 141242 has been marked as a duplicate of this bug. *** |