Bug 217003

Summary: Support OES_fbo_render_mipmap
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, pyalot, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 215599    
Bug Blocks: 141242, 216014    
Attachments:
Description Flags
Patch none

James Darpinian
Reported 2020-09-25 16:50:59 PDT
Support OES_fbo_render_mipmap
Attachments
Patch (26.28 KB, patch)
2020-09-25 16:59 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-09-25 16:59:34 PDT
Created attachment 409761 [details] Patch
Kenneth Russell
Comment 2 2020-09-25 17:05:42 PDT
Comment on attachment 409761 [details] Patch Looks good to me. Have you verified locally that the extension test goes down the code path where the extension's enabled? r+
Dean Jackson
Comment 3 2020-09-25 17:06:53 PDT
Comment on attachment 409761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409761&action=review > Source/WebCore/html/canvas/OESFBORenderMipmap.h:33 > + WTF_MAKE_ISO_ALLOCATED(OESFBORenderMipmap); Thanks for this. We missed that sub-classes need it in the patch where we added IsoHeap allocation to WebGLExtension and it ended up as the number 1 WebKit crash in iOS 14 :)
James Darpinian
Comment 4 2020-09-25 17:07:19 PDT
Comment on attachment 409761 [details] Patch Yes, the extension works locally. Thanks!
EWS
Comment 5 2020-09-25 17:41:41 PDT
Committed r267613: <https://trac.webkit.org/changeset/267613> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409761 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-25 20:57:00 PDT
<rdar://problem/69609581>
Kenneth Russell
Comment 7 2020-09-25 21:54:30 PDT
(In reply to Dean Jackson from comment #3) > Comment on attachment 409761 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409761&action=review > > > Source/WebCore/html/canvas/OESFBORenderMipmap.h:33 > > + WTF_MAKE_ISO_ALLOCATED(OESFBORenderMipmap); > > Thanks for this. We missed that sub-classes need it in the patch where we > added IsoHeap allocation to WebGLExtension and it ended up as the number 1 > WebKit crash in iOS 14 :) I think that was my patch from Bug 215599 - I'm sorry for breaking things!
Alex Christensen
Comment 8 2020-09-26 13:45:57 PDT
http://trac.webkit.org/r267625
Kenneth Russell
Comment 9 2020-10-28 16:34:07 PDT
*** Bug 141242 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.