Bug 216958

Summary: WebKitLegacy should call Page::finalizeRenderingUpdate()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217044
Bug Depends on:    
Bug Blocks: 216726    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
thorton: review+, ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Description Simon Fraser (smfr) 2020-09-24 21:58:22 PDT 
WebKitLegacy should call Page::finalizeRenderingUpdate()
Comment 1 Simon Fraser (smfr) 2020-09-24 22:06:06 PDT 
Created attachment 409656 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-24 23:10:43 PDT 
Created attachment 409659 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-09-25 12:27:02 PDT 
Created attachment 409721 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-09-25 13:30:11 PDT 
Created attachment 409729 [details]
Patch
Comment 5 Tim Horton 2020-09-25 14:51:07 PDT 
Comment on attachment 409729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409729&action=review

> Source/WebCore/page/Page.cpp:1510
> +                page->isolatedUpdateRendering();

Hmm. There's not really "isolation" of any sort. It affects the real world. Is it "out of band"? I don't know what to call it. "updateRenderingWithout..."?
Comment 6 Simon Fraser (smfr) 2020-09-27 13:14:47 PDT 
Created attachment 409857 [details]
Patch
Comment 7 EWS 2020-09-27 16:14:11 PDT 
ChangeLog entry in Source/WebKitLegacy/mac/ChangeLog contains OOPS!.
Comment 8 Simon Fraser (smfr) 2020-09-27 17:24:18 PDT 
https://trac.webkit.org/changeset/267688/webkit
Comment 9 Radar WebKit Bug Importer 2020-09-27 17:25:18 PDT 
<rdar://problem/69669472>