Bug 216957 – [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

and there's FIXME on the LineBox::InlineBox name

[zalan]

Created attachment 409653 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 409653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409653&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37
> +    , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height())

Argument order is confusing because     FloatRect(float x, float y, float width, float height)

[zalan]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 409653 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409653&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37
> > +    , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height())
> 
> Argument order is confusing because     FloatRect(float x, float y, float
> width, float height)
Yeah, in layout I started using top, left, width, height. I might change it later.

[EWS]

Committed r267557: <https://trac.webkit.org/changeset/267557>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409653 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69546533>