Bug 216927

Summary: [GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aperez, berto, bugs-noreply, ews-watchlist, gustavo
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217504
Bug Depends on:    
Bug Blocks: 216041    
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2020-09-24 05:04:13 PDT
Make it per session instead of global to the network process.
Attachments
Patch (47.49 KB, patch)
2020-09-24 05:08 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-09-24 05:08:23 PDT
Created attachment 409561 [details] Patch
EWS Watchlist
Comment 2 2020-09-24 05:08:56 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS
Comment 3 2020-09-24 09:15:00 PDT
Committed r267534: <https://trac.webkit.org/changeset/267534> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409561 [details].
Adrian Perez
Comment 4 2020-09-24 11:40:16 PDT
Comment on attachment 409561 [details] Patch I know this has landed already, but I still want to explicitly write r=me here (the changes look good), because we have the agreement of having two reviewers agree on API changes 👍️
Note You need to log in before you can comment on or make changes to this bug.