Summary: | [GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, aperez, berto, bugs-noreply, ews-watchlist, gustavo | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=217504 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 216041 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2020-09-24 05:04:13 PDT
Created attachment 409561 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Committed r267534: <https://trac.webkit.org/changeset/267534> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409561 [details]. Comment on attachment 409561 [details]
Patch
I know this has landed already, but I still want to explicitly
write r=me here (the changes look good), because we have the
agreement of having two reviewers agree on API changes 👍️
|