Bug 216871

Summary:

Resync WPT's mathml and math-script-level-and-math-style tests

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, dbarton, dpino, ews-watchlist, fred.wang, hector_i_lopez, lmoura, rbuis, rwlbuis, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=215217

Bug Depends on:

Bug Blocks:

216702

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none

Frédéric Wang (:fredw)

Reported 2020-09-23 02:51:07 PDT

Attachments
WIP Patch (800.61 KB, patch) 2020-09-23 02:52 PDT, Frédéric Wang (:fredw)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (892.91 KB, patch) 2020-09-23 07:07 PDT, Frédéric Wang (:fredw)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (1.02 MB, patch) 2020-09-23 10:51 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (1.16 MB, patch) 2020-09-23 11:56 PDT, Frédéric Wang (:fredw)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (1.25 MB, patch) 2020-09-24 01:08 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (1.30 MB, patch) 2020-09-24 02:52 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (1.30 MB, patch) 2020-09-24 03:15 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (1.30 MB, patch) 2020-09-24 04:28 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (1.30 MB, patch) 2020-09-24 06:00 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch for landing (1.30 MB, patch) 2020-09-24 07:42 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch for landing (1.30 MB, patch) 2020-09-24 07:49 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2020-09-23 02:52:20 PDT

Created attachment 409456 [details] WIP Patch

Frédéric Wang (:fredw)

Comment 2 2020-09-23 07:07:01 PDT

Created attachment 409471 [details] Patch

Frédéric Wang (:fredw)

Comment 3 2020-09-23 10:51:33 PDT

Created attachment 409483 [details] Patch

Frédéric Wang (:fredw)

Comment 4 2020-09-23 11:56:21 PDT

Created attachment 409491 [details] Patch

Frédéric Wang (:fredw)

Comment 5 2020-09-24 01:08:38 PDT

Created attachment 409538 [details] Patch

Frédéric Wang (:fredw)

Comment 6 2020-09-24 02:52:08 PDT

Created attachment 409548 [details] Patch

Rob Buis

Comment 7 2020-09-24 03:09:47 PDT

Comment on attachment 409548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409548&action=review > LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/w3c-import.log:22 > +/LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/misc.cpython-38.pyc Is this part intended?

Frédéric Wang (:fredw)

Comment 8 2020-09-24 03:10:49 PDT

Comment on attachment 409548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409548&action=review >> LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/w3c-import.log:22 >> +/LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/misc.cpython-38.pyc > > Is this part intended? probably not, it's likely a bug in the importer.

Frédéric Wang (:fredw)

Comment 9 2020-09-24 03:15:41 PDT

Created attachment 409549 [details] Patch

Frédéric Wang (:fredw)

Comment 10 2020-09-24 04:28:02 PDT

Created attachment 409551 [details] Patch

Frédéric Wang (:fredw)

Comment 11 2020-09-24 06:00:14 PDT

Created attachment 409565 [details] Patch

EWS

Comment 12 2020-09-24 07:36:49 PDT

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Frédéric Wang (:fredw)

Comment 13 2020-09-24 07:42:23 PDT

Created attachment 409576 [details] Patch for landing

EWS

Comment 14 2020-09-24 07:43:20 PDT

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Frédéric Wang (:fredw)

Comment 15 2020-09-24 07:49:45 PDT

Created attachment 409577 [details] Patch for landing

EWS

Comment 16 2020-09-24 08:20:36 PDT

Committed r267531: <https://trac.webkit.org/changeset/267531> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409577 [details].

Radar WebKit Bug Importer

Comment 17 2020-09-24 08:21:22 PDT

<rdar://problem/69504216>

Lauro Moura

Comment 18 2020-09-24 14:59:44 PDT

GTK/WPE baselines updated in r267547. Some tests seems to be slightly flaky in WPE. Will keep an eye on the results in the bots.

Hector Lopez

Comment 19 2020-09-25 11:58:17 PDT

imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html Tests are both missing testing results on macOS wk2. It looks baselines are missing for macOS wk2 from https://trac.webkit.org/changeset/267531/webkit. History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Foperator-dictionary-stretchy-006.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Foperator-dictionary-symmetric-001.html Results: imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html: PASS Operator dictionary chunk 1 - stretchy PASS Operator dictionary chunk 2 - stretchy PASS Operator dictionary chunk 3 - stretchy PASS Operator dictionary chunk 4 - stretchy PASS Operator dictionary chunk 5 - stretchy imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html PASS Operator dictionary chunk 1 - symmetric PASS Operator dictionary chunk 2 - symmetric PASS Operator dictionary chunk 3 - symmetric PASS Operator dictionary chunk 4 - symmetric PASS Operator dictionary chunk 5 - symmetric

Frédéric Wang (:fredw)

Comment 20 2020-09-25 17:53:30 PDT

(In reply to Hector Lopez from comment #19) > imported/w3c/web-platform-tests/mathml/presentation-markup/operators/ > operator-dictionary-stretchy-006.html > imported/w3c/web-platform-tests/mathml/presentation-markup/operators/ > operator-dictionary-symmetric-001.html > > Tests are both missing testing results on macOS wk2. It looks baselines are > missing for macOS wk2 from https://trac.webkit.org/changeset/267531/webkit. > Right, I don't know what happened with these expectations and why EWS didn't detect it. Anyway, I've landed them in https://trac.webkit.org/changeset/267578/webkit since that was detected by EWS there.

Note You need to log in before you can comment on or make changes to this bug.