Summary: | [LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from FloatingState::append | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2020-09-22 19:48:59 PDT
Created attachment 409446 [details]
Patch
Comment on attachment 409446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409446&action=review > Source/WebCore/layout/floats/FloatingState.cpp:68 > + ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) { ASSERT_IMPLIES(floatItem.floatBox(), ....) ? (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409446 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409446&action=review > > > Source/WebCore/layout/floats/FloatingState.cpp:68 > > + ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) { > > ASSERT_IMPLIES(floatItem.floatBox(), ....) ? good point! Created attachment 409447 [details]
Patch
Committed r267460: <https://trac.webkit.org/changeset/267460> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409447 [details]. |