Bug 216866

Summary: [LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from FloatingState::append
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2020-09-22 19:48:59 PDT
ssia
Attachments
Patch (2.41 KB, patch)
2020-09-22 20:00 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2020-09-22 20:07 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-22 20:00:28 PDT
Created attachment 409446 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-09-22 20:02:54 PDT
Comment on attachment 409446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409446&action=review > Source/WebCore/layout/floats/FloatingState.cpp:68 > + ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) { ASSERT_IMPLIES(floatItem.floatBox(), ....) ?
zalan
Comment 3 2020-09-22 20:05:47 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409446 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409446&action=review > > > Source/WebCore/layout/floats/FloatingState.cpp:68 > > + ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) { > > ASSERT_IMPLIES(floatItem.floatBox(), ....) ? good point!
zalan
Comment 4 2020-09-22 20:07:47 PDT
Created attachment 409447 [details] Patch
EWS
Comment 5 2020-09-22 20:48:26 PDT
Committed r267460: <https://trac.webkit.org/changeset/267460> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409447 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-22 21:28:04 PDT
<rdar://problem/69412318>
Note You need to log in before you can comment on or make changes to this bug.