Bug 216866 - [LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from FloatingState::append
Summary: [LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-22 19:48 PDT by zalan
Modified: 2020-09-22 21:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2020-09-22 20:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2020-09-22 20:07 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-22 19:48:59 PDT 
ssia
Comment 1 zalan 2020-09-22 20:00:28 PDT 
Created attachment 409446 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-22 20:02:54 PDT 
Comment on attachment 409446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409446&action=review

> Source/WebCore/layout/floats/FloatingState.cpp:68
> +    ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) {

ASSERT_IMPLIES(floatItem.floatBox(), ....) ?
Comment 3 zalan 2020-09-22 20:05:47 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 409446 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409446&action=review
> 
> > Source/WebCore/layout/floats/FloatingState.cpp:68
> > +    ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) {
> 
> ASSERT_IMPLIES(floatItem.floatBox(), ....) ?
good point!
Comment 4 zalan 2020-09-22 20:07:47 PDT 
Created attachment 409447 [details]
Patch
Comment 5 EWS 2020-09-22 20:48:26 PDT 
Committed r267460: <https://trac.webkit.org/changeset/267460>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409447 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-22 21:28:04 PDT 
<rdar://problem/69412318>