Bug 216865

Summary: Print message saying what project is being built
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ddkilzer, dino, keith_miller, saam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-09-22 19:39:27 PDT
XCBuild removes the progress messages saying which project/target is being built. We can't show the target, but update the Makefiles to at least show which project is being built.
Attachments
Patch (1.26 KB, patch)
2020-09-22 19:41 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-09-22 19:39:38 PDT
<rdar://problem/69408135>
Keith Rollin
Comment 2 2020-09-22 19:41:29 PDT
Created attachment 409445 [details] Patch
Alexey Proskuryakov
Comment 3 2020-09-22 22:50:25 PDT
Would this output make sense when/if we parallelise targets?
Keith Rollin
Comment 4 2020-09-22 22:59:25 PDT
Yes. This output introduces a new project. We build one project at a time, and so those don't get parallelized.
Andy Estes
Comment 5 2020-09-28 11:03:13 PDT
Even once `make` can parallelize across targets, I think this log line will still make sense. It'll just print a workspace name rather than a target name. Maybe we'd also want to enhance it to include the scheme name.
Andy Estes
Comment 6 2020-09-28 11:03:36 PDT
(In reply to Andy Estes from comment #5) > Even once `make` can parallelize across targets Across projects, that is.
EWS
Comment 7 2020-09-28 14:11:47 PDT
Committed r267715: <https://trac.webkit.org/changeset/267715> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409445 [details].
Note You need to log in before you can comment on or make changes to this bug.