Bug 216865 - Print message saying what project is being built
Summary: Print message saying what project is being built
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-22 19:39 PDT by Keith Rollin
Modified: 2020-09-28 14:11 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2020-09-22 19:41 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-09-22 19:39:27 PDT
XCBuild removes the progress messages saying which project/target is being built. We can't show the target, but update the Makefiles to at least show which project is being built.
Comment 1 Radar WebKit Bug Importer 2020-09-22 19:39:38 PDT
<rdar://problem/69408135>
Comment 2 Keith Rollin 2020-09-22 19:41:29 PDT
Created attachment 409445 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-09-22 22:50:25 PDT
Would this output make sense when/if we parallelise targets?
Comment 4 Keith Rollin 2020-09-22 22:59:25 PDT
Yes. This output introduces a new project. We build one project at a time, and so those don't get parallelized.
Comment 5 Andy Estes 2020-09-28 11:03:13 PDT
Even once `make` can parallelize across targets, I think this log line will still make sense. It'll just print a workspace name rather than a target name. Maybe we'd also want to enhance it to include the scheme name.
Comment 6 Andy Estes 2020-09-28 11:03:36 PDT
(In reply to Andy Estes from comment #5)
> Even once `make` can parallelize across targets

Across projects, that is.
Comment 7 EWS 2020-09-28 14:11:47 PDT
Committed r267715: <https://trac.webkit.org/changeset/267715>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409445 [details].