Bug 216855

Summary: Add CSSConditionRule and CSSGroupingRule
Product: WebKit Reporter: Darin Adler <darin>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, keith_miller, kondapallykalyan, macpherson, menard, philipj, ryuan.choi, sam, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216940    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch sam: review+, darin: commit-queue-

Darin Adler
Reported 2020-09-22 15:52:58 PDT
Add CSSConditionRule and CSSGroupingRule
Attachments
Patch (88.74 KB, patch)
2020-09-22 17:03 PDT, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (88.76 KB, patch)
2020-09-22 17:43 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (96.60 KB, patch)
2020-09-24 10:53 PDT, Darin Adler 		sam: review+
darin: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-09-22 17:03:51 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2020-09-22 17:43:56 PDT Comment hidden (obsolete)
Darin Adler
Comment 3 2020-09-24 10:53:13 PDT
Created attachment 409597 [details] Patch
Sam Weinig
Comment 4 2020-09-24 11:20:24 PDT
Comment on attachment 409597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review > Source/WebCore/css/CSSConditionRule.h:18 > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Library General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Library General Public License for more details. > + * > + * You should have received a copy of the GNU Library General Public License > + * along with this library; see the file COPYING.LIB. If not, write to > + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > + * Boston, MA 02110-1301, USA. > + */ You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD.
Darin Adler
Comment 5 2020-09-24 12:06:38 PDT
Comment on attachment 409597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review >> Source/WebCore/css/CSSConditionRule.h:18 >> + */ > > You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD. Oops, will fix that. Sorry, copied from the wrong header.
Darin Adler
Comment 6 2020-09-24 12:07:52 PDT
Comment on attachment 409597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review >>> Source/WebCore/css/CSSConditionRule.h:18 >>> + */ >> >> You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD. > > Oops, will fix that. Sorry, copied from the wrong header. I think I used the correct one above in CSSConditionRule.cpp and that’s what I’ll use on all the new files.
Darin Adler
Comment 7 2020-09-24 15:42:11 PDT
Tests passing, need review. I have fixed the licenses in my local copy.
Darin Adler
Comment 8 2020-09-25 10:19:55 PDT
Committed r267576: <https://trac.webkit.org/changeset/267576>
Radar WebKit Bug Importer
Comment 9 2020-09-25 10:20:18 PDT
<rdar://problem/69579125>
Joonghun Park
Comment 10 2021-09-24 10:25:03 PDT
*** Bug 200838 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.