Bug 216825

Summary: Correct instructions for building iOS in ReadMe
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, jbedard, krollin, pancfmiaomiao, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207043
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2020-09-22 08:41:53 PDT
Chenfeng pointed out in https://bugs.webkit.org/show_bug.cgi?id=207043 that I forgot to update our top level ReadMe to agree with https://webkit.org/building-webkit/.
Attachments
Patch (2.37 KB, patch)
2020-09-22 08:49 PDT, Jonathan Bedard
no flags
Radar WebKit Bug Importer
Comment 1 2020-09-22 08:44:18 PDT
Jonathan Bedard
Comment 2 2020-09-22 08:49:43 PDT
David Kilzer (:ddkilzer)
Comment 3 2020-09-22 09:39:54 PDT
Comment on attachment 409363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409363&action=review > ReadMe.md:99 > +where `platform` is `ios`, `tvos` or `watchos`. Are we sure this is `tvos` and not `appletv`? I've made that mistaken many times. :)
Jonathan Bedard
Comment 4 2020-09-22 09:41:48 PDT
(In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 409363 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409363&action=review > > > ReadMe.md:99 > > +where `platform` is `ios`, `tvos` or `watchos`. > > Are we sure this is `tvos` and not `appletv`? I've made that mistaken many > times. :) Yes, I made sure to check what our builders are passing: https://build.webkit.org/builders/Apple-tvOS-Simulator-13-Release-Build/builds/2605/steps/compile-webkit/logs/stdio
EWS
Comment 5 2020-09-22 09:45:53 PDT
Committed r267416: <https://trac.webkit.org/changeset/267416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409363 [details].
Chenfeng Pan
Comment 6 2020-09-25 01:39:35 PDT
(In reply to Jonathan Bedard from comment #0) > Chenfeng pointed out in https://bugs.webkit.org/show_bug.cgi?id=207043 that > I forgot to update our top level ReadMe to agree with > https://webkit.org/building-webkit/. Sorry I just check my email today. And I find a shell command also needing to be updated.
Note You need to log in before you can comment on or make changes to this bug.