Bug 216793

Summary: [Contact Picker API] Introduce bindings for the Contact Picker API
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, annulen, ap, benjamin, calvaris, cdumez, cmarcelo, dvpdiner2, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Attempt Windows fix
none
Patch
none
Patch
none
Patch none

Aditya Keerthi
Reported 2020-09-21 12:02:17 PDT
Work towards implementing the Contact Picker API.
Attachments
Patch (46.13 KB, patch)
2020-09-21 12:20 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (46.13 KB, patch)
2020-09-21 12:22 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (46.15 KB, patch)
2020-09-21 12:43 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (54.15 KB, patch)
2020-09-21 15:22 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (61.08 KB, patch)
2020-09-22 07:46 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (60.88 KB, patch)
2020-09-22 08:51 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Attempt Windows fix (62.01 KB, patch)
2020-09-22 10:01 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (62.02 KB, patch)
2020-09-22 12:40 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (60.43 KB, patch)
2020-09-23 08:29 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (68.58 KB, patch)
2020-10-02 14:11 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-09-21 12:03:59 PDT
<rdar://problem/69317957>
Aditya Keerthi
Comment 2 2020-09-21 12:20:23 PDT
Created attachment 409296 [details] Patch
Aditya Keerthi
Comment 3 2020-09-21 12:22:27 PDT
Created attachment 409298 [details] Patch
Aditya Keerthi
Comment 4 2020-09-21 12:43:26 PDT
Created attachment 409301 [details] Patch
Aditya Keerthi
Comment 5 2020-09-21 15:22:20 PDT
Created attachment 409328 [details] Patch
Aditya Keerthi
Comment 6 2020-09-22 07:46:33 PDT
Created attachment 409359 [details] Patch
Aditya Keerthi
Comment 7 2020-09-22 08:51:57 PDT
Created attachment 409364 [details] Patch
Aditya Keerthi
Comment 8 2020-09-22 10:01:45 PDT
Created attachment 409373 [details] Attempt Windows fix
Aditya Keerthi
Comment 9 2020-09-22 12:40:55 PDT
Created attachment 409391 [details] Patch
Aditya Keerthi
Comment 10 2020-09-23 08:29:55 PDT
Created attachment 409476 [details] Patch
Aditya Keerthi
Comment 11 2020-10-02 14:11:57 PDT
Created attachment 410369 [details] Patch
Wenson Hsieh
Comment 12 2020-10-02 15:55:52 PDT
Comment on attachment 410369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410369&action=review Looks good overall! I think we might need a clean build for Win EWS though. > LayoutTests/contact-picker/contacts-interfaces.html:22 > + shouldBeTrue("navigator.contacts.select(['name', 'email'], {multiple: true}) instanceof Promise"); I think it would be nice to test a few additional corner cases, like calling select with some strings that don’t map to enum values, or even non-strings, or an empty array, or passing in invalid ContactsSelectOptions.
Aditya Keerthi
Comment 13 2020-10-02 19:55:56 PDT
(In reply to Wenson Hsieh from comment #12) > Comment on attachment 410369 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410369&action=review > > Looks good overall! I think we might need a clean build for Win EWS though. There's no longer a way to force clean builds (the "[clean-build]" functionality was removed). However, I did verify that a clean build passes on Win EWS – see the most recent obsoleted patch for proof. > > LayoutTests/contact-picker/contacts-interfaces.html:22 > > + shouldBeTrue("navigator.contacts.select(['name', 'email'], {multiple: true}) instanceof Promise"); > > I think it would be nice to test a few additional corner cases, like calling > select with some strings that don’t map to enum values, or even non-strings, > or an empty array, or passing in invalid ContactsSelectOptions. I was planning on adding those tests along with the full implementation of ContactsManager.select() if that's alright?
Wenson Hsieh
Comment 14 2020-10-02 21:16:38 PDT
Comment on attachment 410369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410369&action=review >>> LayoutTests/contact-picker/contacts-interfaces.html:22 >>> + shouldBeTrue("navigator.contacts.select(['name', 'email'], {multiple: true}) instanceof Promise"); >> >> I think it would be nice to test a few additional corner cases, like calling select with some strings that don’t map to enum values, or even non-strings, or an empty array, or passing in invalid ContactsSelectOptions. > > I was planning on adding those tests along with the full implementation of ContactsManager.select() if that's alright? Sounds good.
Aditya Keerthi
Comment 15 2020-10-05 11:41:47 PDT
Note: This will require a clean build on Windows bots once landed.
EWS
Comment 16 2020-10-05 11:56:18 PDT
Committed r267988: <https://trac.webkit.org/changeset/267988> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410369 [details].
Note You need to log in before you can comment on or make changes to this bug.