| Summary: | Functions should consistently enumerate length before name | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Keith Miller
2020-09-21 10:25:32 PDT
Created attachment 409287 [details]
Patch
Created attachment 409290 [details]
Patch
Comment on attachment 409290 [details]
Patch
r=me
Comment on attachment 409290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409290&action=review > Source/JavaScriptCore/runtime/InternalFunction.cpp:57 > + // The enumeration order is length then name so we have to make sure we add the properties in that order. /order is length then name so we/order must be length before name. So, we/ Comment on attachment 409290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409290&action=review >> Source/JavaScriptCore/runtime/InternalFunction.cpp:57 >> + // The enumeration order is length then name so we have to make sure we add the properties in that order. > > /order is length then name so we/order must be length before name. So, we/ I changed it to "The enumeration order is length followed by name. So, we make sure to add the properties in that order." Created attachment 409307 [details]
Patch for landing
Committed r267364: <https://trac.webkit.org/changeset/267364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409307 [details]. |