Bug 216773

Summary: [CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cgarcia, clopez, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213990    
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2020-09-21 04:27:34 PDT
On top of modernizing the find module, it should avoid the following warning: -- Checking for module 'atk-bridge-2.0' -- Found atk-bridge-2.0, version 2.34.2 CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE) does not match the name of the calling package (ATKBridge). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) Source/cmake/WebKitFindPackage.cmake:104 (_find_package) Source/cmake/OptionsWPE.cmake:135 (find_package) Source/cmake/WebKitCommon.cmake:58 (include) CMakeLists.txt:173 (include) This warning is for project developers. Use -Wno-dev to suppress it.
Attachments
Patch (7.48 KB, patch)
2020-09-21 05:52 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-09-21 05:52:58 PDT
Created attachment 409273 [details] Patch
Adrian Perez
Comment 2 2020-09-21 23:50:11 PDT
Thanks for the review, Don!
EWS
Comment 3 2020-09-21 23:52:20 PDT
Committed r267399: <https://trac.webkit.org/changeset/267399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409273 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-21 23:53:18 PDT
<rdar://problem/69353421>
Note You need to log in before you can comment on or make changes to this bug.