Bug 216762

Summary: toRTCIceProtocol should handle ssltcp candidates
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description youenn fablet 2020-09-21 00:12:30 PDT 
ssltcp candidates are special unstandardised tcp candidates that are still generated
Comment 1 youenn fablet 2020-09-21 00:13:43 PDT 
Created attachment 409262 [details]
Patch
Comment 2 Darin Adler 2020-09-21 12:44:04 PDT 
Comment on attachment 409262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409262&action=review

> Source/WebCore/ChangeLog:8
> +        Covered by loading hangout.google.com in Debug mode.

Seems like that’s not a great way to regression-test, though. Any thing else we can do?
Comment 3 youenn fablet 2020-09-21 13:19:58 PDT 
> > Source/WebCore/ChangeLog:8
> > +        Covered by loading hangout.google.com in Debug mode.
> 
> Seems like that’s not a great way to regression-test, though. Any thing else
> we can do?

We could use mock peer connection backends.
I'll do that.
Comment 4 youenn fablet 2020-09-22 00:13:12 PDT 
Created attachment 409351 [details]
Patch for landing
Comment 5 EWS 2020-09-22 00:33:12 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 6 youenn fablet 2020-09-22 00:34:52 PDT 
Created attachment 409353 [details]
Patch for landing
Comment 7 EWS 2020-09-22 01:03:43 PDT 
Committed r267401: <https://trac.webkit.org/changeset/267401>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409353 [details].
Comment 8 Radar WebKit Bug Importer 2020-09-22 01:04:15 PDT 
<rdar://problem/69356002>