Bug 216757

Summary:

[LFC][BFC] Move hasClearance out of BoxGeometry

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, sam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2020-09-20 20:13:04 PDT

It belongs in BlockFormattingState

Comment 1 zalan 2020-09-20 20:15:59 PDT

Created attachment 409255 [details]
Patch

Comment 2 Sam Weinig 2020-09-21 06:31:17 PDT

Comment on attachment 409255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409255&action=review

> Source/WebCore/ChangeLog:8
> +        Do not cache the hasClearance state in BoxGeometry.

Would be good to include the rationale for this change here.

Comment 3 EWS 2020-09-21 06:49:12 PDT

Committed r267343: <https://trac.webkit.org/changeset/267343>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409255 [details].

Comment 4 Radar WebKit Bug Importer 2020-09-21 12:16:40 PDT

<rdar://problem/69319234>