| Summary: | [LFC][IFC] InlineFormattingState should not store display lines and runs | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2020-09-19 20:45:31 PDT
Created attachment 409223 [details]
Patch
Created attachment 409224 [details]
Patch
Created attachment 409233 [details]
Patch
Comment on attachment 409233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409233&action=review > Source/WebCore/ChangeLog:15 > + In this patch, > + 1. Display related structures are completely moved out from Layout namespace > + - InlineFormattingContext does not generate display structures. > + - InlineFormattingState only stores layout data. > + - Layout tree verification works on layout geometry. > + - Layout structures do not embed Display types. > + 2. LayoutIntegration creates and maintains the required Display structures for painting and hittesting. > + 3. Display::Run does not use Layout types (InlineLayoutRect, InlineLayoutUnit). Nice! Committed r267325: <https://trac.webkit.org/changeset/267325> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409233 [details]. |