| Summary: | Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | HTML Editing | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, rniwa, sam, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 216325 | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2020-09-19 19:39:19 PDT
Created attachment 409221 [details]
Patch
Comment on attachment 409221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review > Source/WebCore/ChangeLog:8 > + This is covered by tests, but the fix itself is only testable when live range Can we add a test with <!-- test-runner-options? We could, but do you want me to add tests that duplicate the WPT ones that we will just delete when we turn the flag on? I don’t think we should. Comment on attachment 409221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review >> Source/WebCore/ChangeLog:8 >> + This is covered by tests, but the fix itself is only testable when live range > > Can we add a test with <!-- test-runner-options? I’d prefer not to add tests that duplicate the Web Platform Tests coverage. But obviously in this one simple case I could add it. I just don’t think it’s valuable. The Web Platform Tests will be there when we turn the flag on. Committed r267327: <https://trac.webkit.org/changeset/267327> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409221 [details]. |