Bug 216741 – Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Darin Adler]

Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node

[Darin Adler]

Created attachment 409221 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 409221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review

> Source/WebCore/ChangeLog:8
> +        This is covered by tests, but the fix itself is only testable when live range

Can we add a test with <!-- test-runner-options?

[Darin Adler]

We could, but do you want me to add tests that duplicate the WPT ones that we will just delete when we turn the flag on? I don’t think we should.

[Darin Adler]

Comment on attachment 409221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review

>> Source/WebCore/ChangeLog:8
>> +        This is covered by tests, but the fix itself is only testable when live range
> 
> Can we add a test with <!-- test-runner-options?

I’d prefer not to add tests that duplicate the Web Platform Tests coverage. But obviously in this one simple case I could add it. I just don’t think it’s valuable. The Web Platform Tests will be there when we turn the flag on.

[EWS]

Committed r267327: <https://trac.webkit.org/changeset/267327>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409221 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69318338>