Bug 216741 - Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node
Summary: Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 216325
  Show dependency tree / graph
 
Reported: 2020-09-19 19:39 PDT by Darin Adler
Modified: 2020-09-21 12:01 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.52 KB, patch)
2020-09-19 19:46 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-09-19 19:39:19 PDT 
Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node
Comment 1 Darin Adler 2020-09-19 19:46:47 PDT 
Created attachment 409221 [details]
Patch
Comment 2 Ryosuke Niwa 2020-09-19 21:42:06 PDT 
Comment on attachment 409221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review

> Source/WebCore/ChangeLog:8
> +        This is covered by tests, but the fix itself is only testable when live range

Can we add a test with <!-- test-runner-options?
Comment 3 Darin Adler 2020-09-20 11:01:56 PDT 
We could, but do you want me to add tests that duplicate the WPT ones that we will just delete when we turn the flag on? I don’t think we should.
Comment 4 Darin Adler 2020-09-20 11:03:41 PDT 
Comment on attachment 409221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review

>> Source/WebCore/ChangeLog:8
>> +        This is covered by tests, but the fix itself is only testable when live range
> 
> Can we add a test with <!-- test-runner-options?

I’d prefer not to add tests that duplicate the Web Platform Tests coverage. But obviously in this one simple case I could add it. I just don’t think it’s valuable. The Web Platform Tests will be there when we turn the flag on.
Comment 5 EWS 2020-09-20 11:10:24 PDT 
Committed r267327: <https://trac.webkit.org/changeset/267327>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409221 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-21 12:01:30 PDT 
<rdar://problem/69318338>