Bug 216735

Summary:

AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only do FFT analysis once per render quantum

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://www.w3.org/TR/webaudio/#dom-analysernode-getbytefrequencydata

Bug Depends on:

Bug Blocks:

212611, 216736, 216781

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2020-09-19 16:52:55 PDT

AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only do FFT analysis once per render quantum:
- https://www.w3.org/TR/webaudio/#dom-analysernode-getbytefrequencydata

"""
If another call to getByteFrequencyData() or getFloatFrequencyData() occurs within the same render quantum as a previous call, the current frequency data is not updated with the same data. Instead, the previously computed data is returned.
"""

Comment 1 Chris Dumez 2020-09-19 16:59:15 PDT

Created attachment 409215 [details]
Patch

Comment 2 EWS 2020-09-21 11:56:29 PDT

Committed r267349: <https://trac.webkit.org/changeset/267349>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409215 [details].

Comment 3 Radar WebKit Bug Importer 2020-09-21 12:25:52 PDT

<rdar://problem/69319771>