Bug 216729

Summary: [WebIDL] Split up Performance.idl into component partials
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2020-09-19 10:29:21 PDT
[WebIDL] Split up Performance.idl into component partials
Attachments
Patch (17.12 KB, patch)
2020-09-19 10:33 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.16 KB, patch)
2020-09-19 10:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (17.48 KB, patch)
2020-09-19 11:04 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (17.21 KB, patch)
2020-09-22 06:08 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.21 KB, patch)
2020-09-22 06:31 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-19 10:33:18 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-09-19 10:34:53 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-09-19 11:04:33 PDT
Created attachment 409205 [details] Patch
Sam Weinig
Comment 4 2020-09-19 11:07:57 PDT
Reviewers, curious to hear feedback on the new naming scheme for this partial supplements. e.g. Performance+UserTiming.idl, etc. The benefits as I see them are making it clear to someone looking for all the components of a interface and not conflicting with existing interface names (for instance, there is already an interface called PerformanceResourceTiming).
Sam Weinig
Comment 5 2020-09-20 13:20:46 PDT
Anyone want to review?
Darin Adler
Comment 6 2020-09-21 09:51:00 PDT
Comment on attachment 409205 [details] Patch I like these names with + I think.
Sam Weinig
Comment 7 2020-09-22 06:08:57 PDT Comment hidden (obsolete)
Sam Weinig
Comment 8 2020-09-22 06:31:44 PDT
Created attachment 409357 [details] Patch
EWS
Comment 9 2020-09-22 08:28:36 PDT
Committed r267408: <https://trac.webkit.org/changeset/267408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409357 [details].
Radar WebKit Bug Importer
Comment 10 2020-09-22 08:29:17 PDT
<rdar://problem/69371924>
Note You need to log in before you can comment on or make changes to this bug.