| Summary: | Implementation for AXIsolatedObject::nextSibling and previousSibling. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-09-18 12:03:40 PDT
Created attachment 409161 [details]
Patch
Comment on attachment 409161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409161&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347 > + AXObjectCache* objectCache; is this an improvement in style? (In reply to chris fleizach from comment #2) > Comment on attachment 409161 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409161&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347 > > + AXObjectCache* objectCache; > > is this an improvement in style? I guess not... First tried to have just one return statement, that I think was the style improvement, but then I added the check for the object cache which can be null and it is a bit cryptic now. Created attachment 409166 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 409161 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409161&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347 > > + AXObjectCache* objectCache; > > is this an improvement in style? I think it's better in latest revision. Thanks. Committed r267320: <https://trac.webkit.org/changeset/267320> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409166 [details]. |