Bug 216678

Summary: [LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2020-09-17 18:40:40 PDT
This makes LineBox a light, box like class.
Attachments
Patch (54.25 KB, patch)
2020-09-17 19:09 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (54.42 KB, patch)
2020-09-18 03:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-09-17 19:09:35 PDT
Created attachment 409099 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-09-17 19:22:12 PDT
Comment on attachment 409099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409099&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:52 > + const Box& root() const { return formattingContext().root(); } or rootBox()? > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:59 > +struct HangingContent { It's not clear to me what "hanging" is in this context.
alan
Comment 3 2020-09-18 03:25:32 PDT
Created attachment 409123 [details] Patch
EWS
Comment 4 2020-09-18 04:16:39 PDT
Committed r267234: <https://trac.webkit.org/changeset/267234> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409123 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-18 04:17:26 PDT
<rdar://problem/69140016>
Note You need to log in before you can comment on or make changes to this bug.