Bug 216678 - [LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder
Summary: [LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-17 18:40 PDT by zalan
Modified: 2020-09-18 04:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (54.25 KB, patch)
2020-09-17 19:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (54.42 KB, patch)
2020-09-18 03:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-17 18:40:40 PDT 
This makes LineBox a light, box like class.
Comment 1 zalan 2020-09-17 19:09:35 PDT 
Created attachment 409099 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-17 19:22:12 PDT 
Comment on attachment 409099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409099&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:52
> +    const Box& root() const { return formattingContext().root(); }

or rootBox()?

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:59
> +struct HangingContent {

It's not clear to me what "hanging" is in this context.
Comment 3 zalan 2020-09-18 03:25:32 PDT 
Created attachment 409123 [details]
Patch
Comment 4 EWS 2020-09-18 04:16:39 PDT 
Committed r267234: <https://trac.webkit.org/changeset/267234>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409123 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-18 04:17:26 PDT 
<rdar://problem/69140016>