Bug 216660

Summary: WKWebView._tryClose should return whether it succeeded or not
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2020-09-17 13:12:39 PDT
WKWebView._tryClose should return whether it succeeded or not
Comment 1 Alex Christensen 2020-09-17 13:16:34 PDT
Created attachment 409059 [details]
Patch
Comment 2 Sam Weinig 2020-09-17 16:04:50 PDT
Comment on attachment 409059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409059&action=review

> Source/WebKit/ChangeLog:9
> +        The return value of WKPageTryClose is used by Safari.
> +        In order to migrate to WKWebView _tryClose, we need to expose this return value.

API test?
Comment 3 Alex Christensen 2020-09-18 10:37:34 PDT
Created attachment 409144 [details]
Patch
Comment 4 EWS 2020-09-18 13:17:14 PDT
Committed r267279: <https://trac.webkit.org/changeset/267279>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409144 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-18 13:18:19 PDT
<rdar://problem/69171188>