WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216660
WKWebView._tryClose should return whether it succeeded or not
https://bugs.webkit.org/show_bug.cgi?id=216660
Summary
WKWebView._tryClose should return whether it succeeded or not
Alex Christensen
Reported
2020-09-17 13:12:39 PDT
WKWebView._tryClose should return whether it succeeded or not
Attachments
Patch
(2.13 KB, patch)
2020-09-17 13:16 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(3.79 KB, patch)
2020-09-18 10:37 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2020-09-17 13:16:34 PDT
Created
attachment 409059
[details]
Patch
Sam Weinig
Comment 2
2020-09-17 16:04:50 PDT
Comment on
attachment 409059
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=409059&action=review
> Source/WebKit/ChangeLog:9 > + The return value of WKPageTryClose is used by Safari. > + In order to migrate to WKWebView _tryClose, we need to expose this return value.
API test?
Alex Christensen
Comment 3
2020-09-18 10:37:34 PDT
Created
attachment 409144
[details]
Patch
EWS
Comment 4
2020-09-18 13:17:14 PDT
Committed
r267279
: <
https://trac.webkit.org/changeset/267279
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 409144
[details]
.
Radar WebKit Bug Importer
Comment 5
2020-09-18 13:18:19 PDT
<
rdar://problem/69171188
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug