Bug 216654

Summary:

Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, dino, esprehn+autocc, ews-watchlist, graouts, kangil.han, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Antoine Quint

Reported 2020-09-17 10:50:31 PDT

Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData

Attachments
Patch (18.93 KB, patch) 2020-09-17 10:53 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (17.43 KB, patch) 2020-09-17 11:55 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2020-09-17 10:53:34 PDT

Created attachment 409049 [details] Patch

Simon Fraser (smfr)

Comment 2 2020-09-17 10:58:41 PDT

Comment on attachment 409049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409049&action=review > Source/WebCore/animation/DocumentTimeline.cpp:338 > + if (auto* animations = renderer.element()->animations()) { Early return if renderer.element()->animations() is null? > Source/WebCore/animation/DocumentTimeline.cpp:360 > + if (auto* animations = renderer.element()->animations()) { Early return if renderer.element()->animations() is null? > Source/WebCore/animation/DocumentTimeline.cpp:379 > + if (auto* animations = renderer.element()->animations()) { Early return if renderer.element()->animations() is null? > Source/WebCore/animation/DocumentTimeline.cpp:401 > + if (auto* animations = renderer.element()->animations()) { Early return if element or renderer.element()->animations() are null?

Antoine Quint

Comment 3 2020-09-17 11:12:00 PDT

(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409049 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409049&action=review > > > Source/WebCore/animation/DocumentTimeline.cpp:338 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if renderer.element()->animations() is null? > > > Source/WebCore/animation/DocumentTimeline.cpp:360 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if renderer.element()->animations() is null? > > > Source/WebCore/animation/DocumentTimeline.cpp:379 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if renderer.element()->animations() is null? > > > Source/WebCore/animation/DocumentTimeline.cpp:401 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if element or renderer.element()->animations() are null? Yes, yes, yes and yes. Will fix in commit.

Antoine Quint

Comment 4 2020-09-17 11:55:28 PDT

Created attachment 409054 [details] Patch for landing

EWS

Comment 5 2020-09-17 12:28:47 PDT

Committed r267204: <https://trac.webkit.org/changeset/267204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409054 [details].

Radar WebKit Bug Importer

Comment 6 2020-09-17 12:29:16 PDT

<rdar://problem/69088172>

Note You need to log in before you can comment on or make changes to this bug.