Bug 216622

Summary: AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-09-16 14:38:40 PDT
AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer. We are supposed to output silence. However, in order implementation, we were just resetting the offset to 0, playing the buffer from the beginning.
Attachments
Patch (7.47 KB, patch)
2020-09-16 14:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-16 14:43:21 PDT
Created attachment 408957 [details] Patch
Geoffrey Garen
Comment 2 2020-09-16 15:13:16 PDT
Comment on attachment 408957 [details] Patch r=me
EWS
Comment 3 2020-09-16 15:43:19 PDT
Committed r267169: <https://trac.webkit.org/changeset/267169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408957 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-16 15:44:16 PDT
<rdar://problem/69019737>
Note You need to log in before you can comment on or make changes to this bug.