Bug 216622

Summary: AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-09-16 14:38:40 PDT 
AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer. We are supposed to output silence. However, in order implementation, we were just resetting the offset to 0, playing the buffer from the beginning.
Comment 1 Chris Dumez 2020-09-16 14:43:21 PDT 
Created attachment 408957 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-16 15:13:16 PDT 
Comment on attachment 408957 [details]
Patch

r=me
Comment 3 EWS 2020-09-16 15:43:19 PDT 
Committed r267169: <https://trac.webkit.org/changeset/267169>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408957 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-16 15:44:16 PDT 
<rdar://problem/69019737>