Bug 216602

Summary: Build fails with -DENABLE_ACCELERATED_2D_CANVAS=ON
Product: WebKit Reporter: Pablo Saavedra <psaavedra>
Component: WebCore JavaScriptAssignee: Pablo Saavedra <psaavedra>
Severity: Normal CC: aperez, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216193
Description Flags
patch none

Comment 1 Pablo Saavedra 2020-09-16 00:14:33 PDT
Created attachment 408901 [details]
Comment 2 Pablo Saavedra 2020-09-16 00:19:50 PDT
The https://bugs.webkit.org/attachment.cgi?id=408901  patch solve most of the compilation errors but still there is a problem in linking time:

lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlNumberFormatPrototype.cpp.o):IntlNumberFormatPrototype.cpp:function JSC::IntlNumberFormatPrototypeFuncResolvedOptions(JSC::JSGlobalObject*, JSC::CallFrame*): error: undefined reference to 'JSC::IntlNumberFormat::unwrapForOldFunctions(JSC::JSGlobalObject*, JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlNumberFormatPrototype.cpp.o):IntlNumberFormatPrototype.cpp:function JSC::IntlNumberFormatPrototypeGetterFormat(JSC::JSGlobalObject*, JSC::CallFrame*): error: undefined reference to 'JSC::IntlNumberFormat::unwrapForOldFunctions(JSC::JSGlobalObject*, JSC::JSValue)'
collect2: error: ld returned 1 exit status

That part of the code was recently modified by this commit

commit ddc87c0a4c05321205286709f1e073518add1f2f
Author: ysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Sep 5 04:53:16 2020 +0000

    [JSC] Align legacy Intl constructor behavior to spec
    Reviewed by Darin Adler.
Comment 3 Radar WebKit Bug Importer 2020-09-23 00:12:13 PDT
Comment 4 Michael Catanzaro 2020-10-13 07:31:14 PDT
I've just closed all the other ENABLE_ACCELERATED_2D_CANVAS build failures I could find (obsoleted by bug #217603). I'll leave this one in case you want to fix it on 2.30, but probably better to just stop enabling that option.
Comment 5 Adrian Perez 2020-10-13 12:23:03 PDT
We fixed this in bug #217384 — unfortunately that went under my
radar. Pablo, next time please poke us a bit to not let patches
get outdated in Bugzilla; I am sorry for neglecting this one 😓️

Side note: the linker errors about the JSC symbols are unrelated,
and most likely caused by problems masked by unified builds, because
they look similar to the usual stuff we fix when making patches to
keep non-unified builds working.

*** This bug has been marked as a duplicate of bug 217384 ***