Bug 216590 – [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec

[Sam Weinig]

Created attachment 408878 [details]
Patch

[youenn fablet]

Comment on attachment 408878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408878&action=review

> Source/WebCore/page/Navigator.idl:28
> +    // FIXME: Remove this. WebKit is the only engine that still has this.

we could create a bugzilla for it.

> Source/WebCore/page/Navigator.idl:36
> +Navigator includes NavigatorCookies;

Should probably be the first includes to keep lexical order.

[Sam Weinig]

(In reply to youenn fablet from comment #2)
> Comment on attachment 408878 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408878&action=review
> 
> > Source/WebCore/page/Navigator.idl:28
> > +    // FIXME: Remove this. WebKit is the only engine that still has this.
> 
> we could create a bugzilla for it.
> 
> > Source/WebCore/page/Navigator.idl:36
> > +Navigator includes NavigatorCookies;
> 
> Should probably be the first includes to keep lexical order.

This was done to match the order in the spec.

[EWS]

Committed r267146: <https://trac.webkit.org/changeset/267146>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408878 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68991769>