Bug 216574

Summary:	ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for simulator
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	ANGLE	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	dino, kbr, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	iPhone / iPad
OS:	iOS 13
Bug Depends on:	215908
Bug Blocks:	198948

Description Kimmo Kinnunen 2020-09-15 11:48:34 PDT

ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for simulator

- the buffer unpack state probably should be always set when calling glTexImage2D. Now it's only called if textureData != nullptr
- the unpack buffer should be set to nullptr
- the texture data base address should be obtained based on the plane of the texture 
https://developer.apple.com/documentation/iosurface/1419379-iosurfacegetbaseaddressofplane?language=objc

Comment 1 Kenneth Russell 2020-09-15 14:27:44 PDT

Thanks for uncovering these issues Kimmo.

Do you plan to take this? I see I left a few TODOs in ANGLE's src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm .

Comment 2 Radar WebKit Bug Importer 2020-09-22 12:00:28 PDT

<rdar://problem/69384081>

Comment 3 Kimmo Kinnunen 2022-08-11 00:00:18 PDT

EAGL is not supported anymore, closing