Bug 216574
| Summary: | ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for simulator | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | ANGLE | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | dino, kbr, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | iPhone / iPad | ||
| OS: | iOS 13 | ||
| Bug Depends on: | 215908 | ||
| Bug Blocks: | 198948 | ||
Kimmo Kinnunen
ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for simulator
- the buffer unpack state probably should be always set when calling glTexImage2D. Now it's only called if textureData != nullptr
- the unpack buffer should be set to nullptr
- the texture data base address should be obtained based on the plane of the texture
https://developer.apple.com/documentation/iosurface/1419379-iosurfacegetbaseaddressofplane?language=objc
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Russell
Thanks for uncovering these issues Kimmo.
Do you plan to take this? I see I left a few TODOs in ANGLE's src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm .
Radar WebKit Bug Importer
<rdar://problem/69384081>
Kimmo Kinnunen
EAGL is not supported anymore, closing